-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor drop sensor tests #106965
Refactor drop sensor tests #106965
Conversation
Hey there @ChandlerSystems, @pfrazer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass with API change; LGTM. Thanks.
Proposed change
Removes setting states in the CI tests, and the
float
,round
andint
converstions when asserting the state.Somehow the tests seem influence each other, which is not good. The individual tests pass, but when executed together the states seem to be persistant in some cases. For this reason I expect the CI tests to fail.Needs: ChandlerSystems/dropmqttapi#1Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: